Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 )
Change subject: WIP: Pull StatusOr<T> and related tests from protobuf ...................................................................... Patch Set 1: agreed we'd use pair or tuple for multi-out-param use cases, and for "StatusAnd" I think we would just return pair<Status, Foo>, no? Naming-wise, I'm keen on keeping StatusOr<> especially now that Google is open sourcing their own base/ -- it seems plausible that StatusOr<> will show up in there at some time in the not-too-distant future. If that comes to pass, we'll have an easier time moving over to it (or pulling in newer versions via copy-paste at least) -- To view, visit http://gerrit.cloudera.org:8080/8127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2d86a3769da733456956fb892de6d679a011a63 Gerrit-Change-Number: 8127 Gerrit-PatchSet: 1 Gerrit-Owner: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 15:19:40 +0000 Gerrit-HasComments: No
