Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 )
Change subject: WIP: Pull StatusOr<T> and related tests from protobuf ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8127/1/src/kudu/util/statusor.h File src/kudu/util/statusor.h: http://gerrit.cloudera.org:8080/#/c/8127/1/src/kudu/util/statusor.h@94 PS1, Line 94: class StatusOr { > Let's bikeshed away :) It's not like this is urgent. OK makes sense - I'd consider my feedback as a 'vote'. If no one else feels strongly the same way then let's go with 'StatusOr'. -- To view, visit http://gerrit.cloudera.org:8080/8127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2d86a3769da733456956fb892de6d679a011a63 Gerrit-Change-Number: 8127 Gerrit-PatchSet: 1 Gerrit-Owner: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 25 Sep 2017 17:31:36 +0000 Gerrit-HasComments: Yes
