Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8115
to look at the new patch set (#2).
Change subject: thirdparty: fix to protobuf bump
......................................................................
thirdparty: fix to protobuf bump
Commit 57de48d bumped protobuf to 3.4.1 but didn't remove the call to
delete_if_wrong_patchlevel, which meant that every time
download-thirdparty.sh was run, it'd redownload and reextract protobuf.
Rather than remove delete_if_wrong_patchlevel, this patch sets protobuf to
use patchlevel 0. That way, download-thirdparty.sh will rebuild protobuf
when switching between different git branches with differing protobuf
patchlevels. If we had removed the patchlevel altogether, it wouldn't be
smart enough to recognize a change and rebuild when switching back to "now".
Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
---
M thirdparty/download-thirdparty.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/8115/2
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
