Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump ...................................................................... Patch Set 1: > Patch Set 1: > > |I removed the patch level stuff in the recent Protobuf 3.3 -> 3.4 bump, > since we aren't carrying any pb patches, and we don't kneed the patch level > to differentiate a change in build flags. Are we gravitating towards always > specifying a patch level now? > > Seemed like it from the comments on that patch and by the way that thirparty > lib was added, which was why I asked. Yea, I am +1 on always adding a patchlevel even if it's 0. This allows us to go to 1 and still trigger a rebuild when building past branches that are at level 0 -- To view, visit http://gerrit.cloudera.org:8080/8115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0 Gerrit-Change-Number: 8115 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 23:40:17 +0000 Gerrit-HasComments: No
