Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump ...................................................................... thirdparty: fix to protobuf bump Commit 57de48d bumped protobuf to 3.4.1 but didn't remove the call to delete_if_wrong_patchlevel, which meant that every time download-thirdparty.sh was run, it'd redownload and reextract protobuf. Rather than remove delete_if_wrong_patchlevel, this patch sets protobuf to use patchlevel 0. That way, download-thirdparty.sh will rebuild protobuf when switching between different git branches with differing protobuf patchlevels. If we had removed the patchlevel altogether, it wouldn't be smart enough to recognize a change and rebuild when switching back to "now". Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0 Reviewed-on: http://gerrit.cloudera.org:8080/8115 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves <davidral...@gmail.com> --- M thirdparty/download-thirdparty.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified David Ribeiro Alves: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0 Gerrit-Change-Number: 8115 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
