Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 )
Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/8089/8/src/kudu/util/cow_object.h File src/kudu/util/cow_object.h: http://gerrit.cloudera.org:8080/#/c/8089/8/src/kudu/util/cow_object.h@328 PS8, Line 328: break; > nit: just to be in sync with the code at line 397, consider moving this to Done http://gerrit.cloudera.org:8080/#/c/8089/8/src/kudu/util/cow_object.h@375 PS8, Line 375: DCHECK_EQ(r.first->second, object); > Nice. That's what I also asked to add in my review for PS2. Yes, now that I'm rereading what you wrote, I see that I missed that part of your suggestion. Sorry about that. -- To view, visit http://gerrit.cloudera.org:8080/8089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Gerrit-Change-Number: 8089 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2017 18:37:15 +0000 Gerrit-HasComments: Yes
