Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8089 )
Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ...................................................................... catalog_manager: make ScopedTabletInfoCommitter generic I want to use it for TableInfo mutations, and to manage multiple read locks too. So I've moved it to util/cow_object, created a read-only variant, and templatized them for any CowObject. Importantly, the default out-of-scope behavior is now Unlock(). Previously it was Commit(), but I think Unlock() is less surprising. Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Reviewed-on: http://gerrit.cloudera.org:8080/8089 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/integration-tests/create-table-stress-test.cc M src/kudu/master/catalog_manager-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master-path-handlers.cc M src/kudu/master/sys_catalog-test.cc M src/kudu/master/sys_catalog.cc M src/kudu/util/CMakeLists.txt A src/kudu/util/cow_object.cc M src/kudu/util/cow_object.h 10 files changed, 439 insertions(+), 306 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Gerrit-Change-Number: 8089 Gerrit-PatchSet: 10 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
