Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8204 )
Change subject: KUDU-2167: fix C++ client crash due to bad assumption regarding scan data ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8204/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/8204/1/src/kudu/client/client-test.cc@5310 PS1, Line 5310: TEST_F(ClientTest, TestSubsequentScanRequestReturnsNoData) { can you add a comment pointing back to the bug that this is a regression test for? http://gerrit.cloudera.org:8080/#/c/8204/1/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/8204/1/src/kudu/client/scanner-internal.cc@556 PS1, Line 556: if (!resp_data) { this looks reasonable on the client side. I wonder if we should also patch the server side to send an empty 'resp_data' string even in the case that it returns no rows? that way old clients talking to new servers would also avoid the crash? -- To view, visit http://gerrit.cloudera.org:8080/8204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1a8a4e22082cf39710b9f00894f644a0b34234e Gerrit-Change-Number: 8204 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 00:18:17 +0000 Gerrit-HasComments: Yes
