Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8204 )
Change subject: KUDU-2167: fix C++ client crash due to bad assumption regarding scan data ...................................................................... Patch Set 2: > Patch Set 2: > > > Do you mind running a quick test with an old client against a new server, > > sending a predicate that matches nothing? Does the lack of the change in > > 'has_data_in_open_' in the old client cause any problem? > > OK, I modified samples.cc to insert some data, scan with a batch size of 0, > and use a predicate that filters out everything. > - Old client and old server: crashed. > - New client and old server: no crash, looped over one empty batch. > - New client and new server: no crash, looped over one empty batch. > - Old client and new server: no crash, looped over two empty batches (the old > data_in_open_ behavior leads to an extra HasMoreRows()==true). > > Let me know if you have any other tests in mind. Sounds good, that was more or less what I had in mind. -- To view, visit http://gerrit.cloudera.org:8080/8204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1a8a4e22082cf39710b9f00894f644a0b34234e Gerrit-Change-Number: 8204 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 02:08:57 +0000 Gerrit-HasComments: No
