Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8222
to review the following change.
Change subject: KUDU-2173: Partitions are pruned incorrectly when
range-partitioned on a PK prefix
......................................................................
KUDU-2173: Partitions are pruned incorrectly when range-partitioned on a PK
prefix
The partition pruner mistakenly treated a range partition which is a
proper prefix of a primary key as an exclusive bound, when in fact it's
an inclusive bound when the remaining PK column constraints are greater
than the min value.
This is a C++-only bug; the Java client only attempts to use the PK as
the range partition bounds when the primary key columns match the range
partition columns exactly. Regardless, I added a few Java tests just to
ensure it won't regress.
Change-Id: I38752f50c0910cd157a912eaa272c76a1a0d9b59
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M src/kudu/common/key_util.cc
M src/kudu/common/key_util.h
M src/kudu/common/partial_row.h
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/partition_pruner.cc
6 files changed, 236 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/8222/1
--
To view, visit http://gerrit.cloudera.org:8080/8222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38752f50c0910cd157a912eaa272c76a1a0d9b59
Gerrit-Change-Number: 8222
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
