Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8222 )
Change subject: KUDU-2173: Partitions are incorrectly pruned when range-partitioned on a PK prefix ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8222/2/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/8222/2/src/kudu/common/partition_pruner.cc@139 PS2, Line 139: Arena arena(std::max<size_t>(Arena::kMinimumChunkSize, schema.key_byte_size()), 4096); > can move this inside the if statement below It has to outlive the call to EncodeKey. -- To view, visit http://gerrit.cloudera.org:8080/8222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38752f50c0910cd157a912eaa272c76a1a0d9b59 Gerrit-Change-Number: 8222 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2017 21:21:58 +0000 Gerrit-HasComments: Yes
