Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8222 )
Change subject: KUDU-2173: Partitions are incorrectly pruned when range-partitioned on a PK prefix ...................................................................... KUDU-2173: Partitions are incorrectly pruned when range-partitioned on a PK prefix The partition pruner mistakenly treated a range partition which is a proper prefix of a primary key as an exclusive bound, when in fact it's an inclusive bound if the remaining PK column constraints are greater than the min value. This is a C++-only bug; the Java client only attempts to use the PK as the range partition bound when the primary key columns match the range partition columns exactly (see KUDU-2178). Regardless, I added Java regression tests in order to cover the case when the Java pruner is improved. Change-Id: I38752f50c0910cd157a912eaa272c76a1a0d9b59 Reviewed-on: http://gerrit.cloudera.org:8080/8222 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java M src/kudu/common/key_util.cc M src/kudu/common/key_util.h M src/kudu/common/partial_row.h M src/kudu/common/partition_pruner-test.cc M src/kudu/common/partition_pruner.cc 6 files changed, 320 insertions(+), 42 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I38752f50c0910cd157a912eaa272c76a1a0d9b59 Gerrit-Change-Number: 8222 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
