Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8213 )

Change subject: java client: fix TestKuduTable.testAlterNoWait
......................................................................


Patch Set 2:

(1 comment)

> Could you point out in the commit message what issue this is fixing?  I can't 
> see how the new code is substantively different.

Sure, added a better description to the commit message.

http://gerrit.cloudera.org:8080/#/c/8213/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/8213/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java@610
PS2, Line 610:       syncClient.isAlterTableDone(tableName);
> maybe wrap in an assert?
Done



--
To view, visit http://gerrit.cloudera.org:8080/8213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I498413ad118631eebda2d16d6c22727409214896
Gerrit-Change-Number: 8213
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 09 Oct 2017 23:43:55 +0000
Gerrit-HasComments: Yes

Reply via email to