Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8213 )
Change subject: java client: fix TestKuduTable.testAlterNoWait ...................................................................... java client: fix TestKuduTable.testAlterNoWait There were a couple issues here, some cosmetic and some real: - The first block comment incorrectly referred to oldName instead of newName as the column being checked. - After newName was found to be non-existent, the second check should have reused the same KuduTable and should have checked oldName, but it checked newName again, expecting it to exist. That adds no value and makes the test flaky (i.e. if the alter finishes in between, the test fails). - In the check after the call to isAlterTableDone, the fail() message was backwards; oldName should not exist at this point. Change-Id: I498413ad118631eebda2d16d6c22727409214896 Reviewed-on: http://gerrit.cloudera.org:8080/8213 Tested-by: Adar Dembo <[email protected]> Reviewed-by: Dan Burkert <[email protected]> --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java 1 file changed, 18 insertions(+), 16 deletions(-) Approvals: Adar Dembo: Verified Dan Burkert: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I498413ad118631eebda2d16d6c22727409214896 Gerrit-Change-Number: 8213 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]>
