Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8213
to look at the new patch set (#3).
Change subject: java client: fix TestKuduTable.testAlterNoWait
......................................................................
java client: fix TestKuduTable.testAlterNoWait
There were a couple issues here, some cosmetic and some real:
- The first block comment incorrectly referred to oldName instead of
newName as the column being checked.
- After newName was found to be non-existent, the second check should have
reused the same KuduTable and should have checked oldName, but it checked
newName again, expecting it to exist. That adds no value and makes the
test flaky (i.e. if the alter finishes in between, the test fails).
- In the check after the call to isAlterTableDone, the fail() message was
backwards; oldName should not exist at this point.
Change-Id: I498413ad118631eebda2d16d6c22727409214896
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
1 file changed, 18 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/8213/3
--
To view, visit http://gerrit.cloudera.org:8080/8213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I498413ad118631eebda2d16d6c22727409214896
Gerrit-Change-Number: 8213
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
