David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 )
Change subject: KUDU-2184. Avoid allocations larger than 1MB ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8239/4/src/kudu/util/memory/arena.cc File src/kudu/util/memory/arena.cc: http://gerrit.cloudera.org:8080/#/c/8239/4/src/kudu/util/memory/arena.cc@42 PS4, Line 42: 1024 * 1024 I don't have a notion of whats the proportion of the places where you changed this vs the rest. If it's high, i.e. if you've changed this in the majority of places maybe we should come up with a flag or something that would set this for most cases and maybe justify when we chose a different value? it's messy to have all these magical numbers sprinkled all over the code base -- To view, visit http://gerrit.cloudera.org:8080/8239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19c8ae9ce268e2623a89624e19db673931a093c0 Gerrit-Change-Number: 8239 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 10 Oct 2017 20:50:21 +0000 Gerrit-HasComments: Yes
