Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8239
to review the following change.
Change subject: KUDU-2184. Avoid allocations larger than 1MB
......................................................................
KUDU-2184. Avoid allocations larger than 1MB
tcmalloc doesn't perform well for allocations larger than 1MB[1]. We
currently use large allocations for full arenas (in particular the MRS)
which can cause large latency blips when a thread tries to allocate a
new arena component.
This just changes the max buffer size for all arenas to be 1MB and adds
a DCHECK so we avoid this problem in the future.
Additionally I increased the buffer size for the /memz output so that we
can get more stats on the occupancy of different allocator size classes.
[1] https://github.com/gperftools/gperftools/issues/535
Change-Id: I19c8ae9ce268e2623a89624e19db673931a093c0
---
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_util.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tablet/transactions/transaction.cc
M src/kudu/util/memory/arena.cc
12 files changed, 19 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/8239/1
--
To view, visit http://gerrit.cloudera.org:8080/8239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19c8ae9ce268e2623a89624e19db673931a093c0
Gerrit-Change-Number: 8239
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
