Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 )
Change subject: KUDU-2184. Avoid allocations larger than 1MB ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8239/4/src/kudu/util/memory/arena.cc File src/kudu/util/memory/arena.cc: http://gerrit.cloudera.org:8080/#/c/8239/4/src/kudu/util/memory/arena.cc@42 PS4, Line 42: 1024 * 1024 > I don't have a notion of whats the proportion of the places where you chang yea, I thought about changing this to either use a default value or to not have the parameter at all (and just use 1MB everywhere). But I think there are actually some reasons to prefer small or large for different arena use cases so I wanted to leave it. Mind if I defer this so that this can be a simple change that's backportable? -- To view, visit http://gerrit.cloudera.org:8080/8239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19c8ae9ce268e2623a89624e19db673931a093c0 Gerrit-Change-Number: 8239 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 10 Oct 2017 21:14:31 +0000 Gerrit-HasComments: Yes
