Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )
Change subject: [consensus] do not call EnableFailureDetector twice ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.h@a553 PS2, Line 553: Why remove this comment? http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc@582 PS2, Line 582: EnableFailureDetector(std::move(fd_delta)); If fd_delta is boost::none, won't that mean we'll configure the FD to expire immediately? Maybe that's why one of the raft_consensus-itest instances is failing? -- To view, visit http://gerrit.cloudera.org:8080/8271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822 Gerrit-Change-Number: 8271 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 13 Oct 2017 21:35:36 +0000 Gerrit-HasComments: Yes
