Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc@582
PS2, Line 582:   EnableFailureDetector(std::move(fd_delta));
> Ah yes, you're right. I don't know why the test is failing then.
It seems that was due to out-of-memory errors in TSAN mode due to recent 
changes.  Todd already posted a patch to flush 'shadow' TSAN memory every 10 
seconds, which makes fixed the issue.



--
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Sun, 15 Oct 2017 05:56:34 +0000
Gerrit-HasComments: Yes

Reply via email to