Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )
Change subject: [consensus] do not call EnableFailureDetector twice ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h@558 PS5, Line 558: delta > I don't know why clang-tidy didn't catch this but this should be fd_delta s nope, that should be delta, and it corresponds to the notation in the *.cc file. -- To view, visit http://gerrit.cloudera.org:8080/8271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822 Gerrit-Change-Number: 8271 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 16 Oct 2017 17:58:26 +0000 Gerrit-HasComments: Yes
