Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8269 )
Change subject: arena: remove second parameter for max buffer size ...................................................................... Patch Set 2: (2 comments) > Patch Set 1: > > Thanks for doing this. Did you run a quick perf smoke test? I didn't run a perf test, but I tried to keep the same settings for anything perf-sensitive. I think any perf regressions here would be more likely to show up in system-level tests rather than in micro-benchmarks anyway, since the large allocations only become slow in tcmalloc once the heap is fragmented. http://gerrit.cloudera.org:8080/#/c/8269/1/src/kudu/util/memory/arena.h File src/kudu/util/memory/arena.h: http://gerrit.cloudera.org:8080/#/c/8269/1/src/kudu/util/memory/arena.h@95 PS1, Line 95: ArenaBase(BufferAllocator* buffer_allocator, > warning: parameter 'buffer_allocator' is const-qualified in the function de Done http://gerrit.cloudera.org:8080/#/c/8269/1/src/kudu/util/memory/arena.h@99 PS1, Line 99: explicit ArenaBase(size_t initial_buffer_size); > warning: single-argument constructors must be marked explicit to avoid unin Done -- To view, visit http://gerrit.cloudera.org:8080/8269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56d7bb5b689c608382423038f11013b6be39e656 Gerrit-Change-Number: 8269 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 17 Oct 2017 20:47:28 +0000 Gerrit-HasComments: Yes
