Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8269 )
Change subject: arena: remove second parameter for max buffer size ...................................................................... arena: remove second parameter for max buffer size It was never very obvious how to pick a value for the max buffer size of an Arena, and upon some reflection I think 1MB is almost always the right choice. So, this removes the parameter for it from the constructor, and instead adds a setter for the rare case when it needs to be customized. Change-Id: I56d7bb5b689c608382423038f11013b6be39e656 Reviewed-on: http://gerrit.cloudera.org:8080/8269 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/cfile/binary_dict_block.cc M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/encoding-test.cc M src/kudu/client/scan_configuration.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc M src/kudu/common/columnblock.h M src/kudu/common/encoded_key-test.cc M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/key_util-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition_pruner-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/row.h M src/kudu/common/row_operations-test.cc M src/kudu/common/scan_spec-test.cc M src/kudu/common/schema-test.cc M src/kudu/common/schema.cc M src/kudu/common/wire_protocol-test.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/cbtree-test.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/composite-pushdown-test.cc M src/kudu/tablet/concurrent_btree.h M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_store.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-pushdown-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tablet/transactions/transaction.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tserver/scanners.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc M src/kudu/util/inline_slice-test.cc M src/kudu/util/memory/arena-test.cc M src/kudu/util/memory/arena.cc M src/kudu/util/memory/arena.h M src/kudu/util/trace.cc 57 files changed, 159 insertions(+), 136 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I56d7bb5b689c608382423038f11013b6be39e656 Gerrit-Change-Number: 8269 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
