Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 )
Change subject: KUDU-2191 (2/n): Hive Metastore client ...................................................................... Patch Set 26: (5 comments) http://gerrit.cloudera.org:8080/#/c/7053/25/src/kudu/hms/hms_client.cc File src/kudu/hms/hms_client.cc: http://gerrit.cloudera.org:8080/#/c/7053/25/src/kudu/hms/hms_client.cc@99 PS25, Line 99: shared_ptr<TSocket> socket(new TSocket(hms_address.host(), hms_address.port())); Can we use std::make_shared here? http://gerrit.cloudera.org:8080/#/c/7053/24/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/7053/24/src/kudu/hms/mini_hms.cc@125 PS24, Line 125: 'datanucleus.schem > Which options is this referring to? datanucleus.schema.autoCreateAll and hi I think you missed this one. http://gerrit.cloudera.org:8080/#/c/7053/22/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/7053/22/thirdparty/vars.sh@212 PS22, Line 212: BISON_NAME=bison-$BISON_VERSION > I'm not sure, I always just download the tarball via GitHub's 'download' bu PS26 has more info about how we don't use a release, but the provenance is still incomplete (i.e. it needs a URL to a repository). http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh@203 PS26, Line 203: # TODO(dan): bump to 0.11 when it's released. We chose to use a bleeding edge Could you also include a URL here to the Thrift repo? http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh@206 PS26, Line 206: . Nit: got an extra period here. -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-Change-Number: 7053 Gerrit-PatchSet: 26 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 18 Oct 2017 22:45:55 +0000 Gerrit-HasComments: Yes