Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 )
Change subject: KUDU-2191 (2/n): Hive Metastore client ...................................................................... Patch Set 27: (4 comments) http://gerrit.cloudera.org:8080/#/c/7053/24/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/7053/24/src/kudu/hms/mini_hms.cc@101 PS24, Line 101: map<string, string> env_vars { > nit: const ? Why should this variable in particular be const? http://gerrit.cloudera.org:8080/#/c/7053/22/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/7053/22/thirdparty/vars.sh@212 PS22, Line 212: BISON_NAME=bison-$BISON_VERSION > PS26 has more info about how we don't use a release, but the provenance is It's a SHA from the upstream Apache git repository. Can we not assume contributors to Apache Kudu can find the Apache Hive repository? http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh@203 PS26, Line 203: # TODO(dan): bump to 0.11 when it's released. We chose to use a bleeding edge > Could you also include a URL here to the Thrift repo? The Apache project page is linked to in the license file. The apache git repo has a pretty useless web ui. http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh@206 PS26, Line 206: . > Nit: got an extra period here. Done -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-Change-Number: 7053 Gerrit-PatchSet: 27 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Oct 2017 01:26:51 +0000 Gerrit-HasComments: Yes
