David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: mvcc: allow tablet shutdown without completing txs ...................................................................... Patch Set 20: (5 comments) http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tablet/tablet.h@537 PS20, Line 537: // Returns an error if the tablet has been stopped, e.g. because the tablet : // needs to be closed due to an error. : Status CheckNotStopped() const; can't you just use the corresponding method in mvcc? http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tablet/tablet.cc@827 PS20, Line 827: Failed to check presence of rows nit: how about "Error while checking roe presence" http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tablet/tablet.cc@839 PS20, Line 839: Stopped() PREDICT_FALSE? http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tablet/tablet.cc@900 PS20, Line 900: return Status::Aborted("Transaction failed because tablet was stopped"); can't you use CheckNotStopped here http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/7439/20/src/kudu/tserver/tablet_service.cc@1731 PS20, Line 1731: // If we get a Status::Aborted() from HandleScanAtSnapshot(), it likely : // means the tablet had to shut down, e.g. due to a disk error. this sentence seems incomplete, so what do we do? -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 20 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2017 20:06:55 +0000 Gerrit-HasComments: Yes
