David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: mvcc: allow tablet shutdown without completing txs ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/mvcc.h@277 PS15, Line 277: SetShuttingDown since there is no "action" this entity is doing maybe "closed" with be a better term? http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/tablet.h@405 PS15, Line 405: // Stops the tablet. Once called, currently-Applying operations should : // terminate early, and further transactions should be aborted. : void Stop(); : : bool Stopped() const { : return mvcc_.IsShuttingDown(); : } I don't think we need this in tablet, since it's a plain proxy to mvcc which is already pulled out in several places http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/tablet.cc@438 PS15, Line 438: gscoped_ptr<ScopedTransaction> mvcc_tx; : DCHECK(tx_state->has_timestamp()); : mvcc_tx.reset(new ScopedTransaction(&mvcc_, tx_state->timestamp())); : tx_state->SetMvccTx(std::move(mvcc_tx)); I though we had discussed having transactions fail on the prepare phase if mvcc was shutdown/closed. This would be the place to do it, I think. -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 00:00:02 +0000 Gerrit-HasComments: Yes
