David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: mvcc: allow tablet shutdown without completing txs ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: http://gerrit.cloudera.org:8080/#/c/7439/15/src/kudu/tablet/transactions/transaction_driver.cc@133 PS15, Line 133: TabletReplica* replica = transaction->state()->tablet_replica(); : if (PREDICT_FALSE(replica && replica->tablet()->Stopped())) { : return Status::Aborted("Not executing transaction; tablet has been stopped"); : } Intuitively I would say this closes the window to the scenario that was closing errors in dist test but doesn't close it completely. TBH I'm not even sure my suggestion does it. Nastier tests might be able to prove me wrong. The reason I say it is because theres a chance that both attempts of the same txn are able to pass through here and go to prepare. It's smaller now, but it's still there, I think -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2017 00:14:13 +0000 Gerrit-HasComments: Yes
