Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 )
Change subject: [java client] improve AsyncKuduScanner logging ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8382/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8382/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@727 PS3, Line 727: ret += ", lastPrimaryKey = " + Bytes.pretty(lastPrimaryKey); > Hmm, you are right. Do you think it makes sense to log a hashed value for d I'd lean on the side of not exposing it, since it's somewhat complicated to use a crypto-secure hash (calling hashCode() isn't sufficient). But if you think it's worth the effort in terms of increased debug-ability, then go for it. -- To view, visit http://gerrit.cloudera.org:8080/8382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ffcd01e7f99f3090fa118092fc303e06fb92dc Gerrit-Change-Number: 8382 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 30 Oct 2017 16:07:16 +0000 Gerrit-HasComments: Yes
