Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 )
Change subject: [java client] improve AsyncKuduScanner logging ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/8382/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8382/1//COMMIT_MSG@7 PS1, Line 7: improve > improve Done http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@509 PS1, Line 509: FaultTolerantScannerExp > I guess that's a bit better. Also that class' javadoc needs to specify that Done http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@515 PS1, Line 515: } else { > Since you're adding the lastPrimariKey to toString() and that we'd also wan Done http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@520 PS1, Line 520: : public String toString() > nit here and above: consider using 'formatted' version like Done http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@888 PS1, Line 888: : AsyncKuduClient.NO_TIMESTAMP, > Isn't that overriding what we do on line 403? Instead on line 897 I'd just Done http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@904 PS1, Line 904: > mind also removing "Slice" here? It's an old artefact. Done http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java@400 PS1, Line 400: } : : reportError( > readability nit: could you remove 'else' here? Done -- To view, visit http://gerrit.cloudera.org:8080/8382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ffcd01e7f99f3090fa118092fc303e06fb92dc Gerrit-Change-Number: 8382 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2017 23:09:31 +0000 Gerrit-HasComments: Yes
