Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 )
Change subject: [java client] improve AsyncKuduScanner logging ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8382/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8382/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@512 PS2, Line 512: Encounter FaultTolerantScannerExpiredException, retry fault " + : "tolerant scanner That's all very redundant (also nit: Encountered). I'd just put "Scanner expired, creating a new one {}" http://gerrit.cloudera.org:8080/#/c/8382/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@592 PS2, Line 592: } Add here if the scanner is fault tolerant then all the lines will now contain this useful information. http://gerrit.cloudera.org:8080/#/c/8382/2/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: http://gerrit.cloudera.org:8080/#/c/8382/2/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java@402 PS2, Line 402: reportError("Row count unexpectedly decreased from " + lastRowCount + "to " + rowCount, Did you do a dist test with this new change? It's possible we might have been riding over other issues. -- To view, visit http://gerrit.cloudera.org:8080/8382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ffcd01e7f99f3090fa118092fc303e06fb92dc Gerrit-Change-Number: 8382 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2017 17:39:58 +0000 Gerrit-HasComments: Yes
