Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 )
Change subject: [RaftPeerPB] introduce new status fields ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8561/2/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: http://gerrit.cloudera.org:8080/#/c/8561/2/src/kudu/consensus/metadata.proto@61 PS2, Line 61: enum HealthStatus { : UNKNOWN_HEALTH_STATUS = 999; : HEALTHY = 0; // Replica is functioning properly. : FAILED = 1; // Replica has failed and needs replacement. : }; Since we may want to extend the number of health flags in the future what do you think about pulling this enum out of RaftPeerPB and put it in a separate top-level message such as HealthStatusPB? Something like message HealthReportPB { enum HealthStatusPB { UNKNOWN = 999; FAILED = 0; HEALTHY = 1; } optional HealthStatusPB overall_health = 0; } message RaftPeerPB { ... optional HealthReportPB health_report; } http://gerrit.cloudera.org:8080/#/c/8561/2/src/kudu/consensus/metadata.proto@82 PS2, Line 82: do_promote nit: I'd personally prefer not to have the "do_" prefix here, but if you feel it's very helpful for understanding I can get behind it. Also, regarding the promote / replace attributes, perhaps we should also nest them in a message so that extending it later is more encapsulated? They are logically related to each other. I was thinking something like: message RaftPeerAttrsPB { optional bool promote; optional bool replace; } message RaftPeerPB { ... optional RaftPeerAttrsPB attrs; } -- To view, visit http://gerrit.cloudera.org:8080/8561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82f838fd3612ab9bc3f91cac7a840cb9f36ff4c Gerrit-Change-Number: 8561 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 16 Nov 2017 20:53:51 +0000 Gerrit-HasComments: Yes
