Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8755 )
Change subject: KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional ...................................................................... Patch Set 2: (3 comments) lgtm, just a few nits. http://gerrit.cloudera.org:8080/#/c/8755/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java: http://gerrit.cloudera.org:8080/#/c/8755/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java@1 PS2, Line 1: package org.apache.kudu.client; licensing nit: add ASF copyright header? http://gerrit.cloudera.org:8080/#/c/8755/2/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8755/2/src/kudu/rpc/client_negotiation.cc@418 PS2, Line 418: set<SaslMechanism::Type> common_mechs Is it needed? http://gerrit.cloudera.org:8080/#/c/8755/2/src/kudu/security/tls_handshake.cc File src/kudu/security/tls_handshake.cc: http://gerrit.cloudera.org:8080/#/c/8755/2/src/kudu/security/tls_handshake.cc@259 PS2, Line 259: (cipher == nullptr) style nit: mind updating this to be '(!cipher)' to be in sync with the code below? -- To view, visit http://gerrit.cloudera.org:8080/8755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276 Gerrit-Change-Number: 8755 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 05 Dec 2017 19:56:21 +0000 Gerrit-HasComments: Yes
