Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8755 )
Change subject: KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional ...................................................................... Patch Set 5: Code-Review+2 (4 comments) Looks good, just a few nits, feel free to ignore. http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/integration-tests/security-faults-itest.cc File src/kudu/integration-tests/security-faults-itest.cc: http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/integration-tests/security-faults-itest.cc@a248 PS5, Line 248: : : : : That's good it's gone now. http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/integration-tests/security-itest.cc@a185 PS5, Line 185: nit: maybe, it's worth keeping this line of the description for this test? http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@789 PS5, Line 789: OM_uint32 minor nit: maybe, move this under the 'do {} while()' scope below? http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@790 PS5, Line 790: gss_buffer_desc buf; ditto -- To view, visit http://gerrit.cloudera.org:8080/8755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276 Gerrit-Change-Number: 8755 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 07 Dec 2017 04:28:26 +0000 Gerrit-HasComments: Yes
