Hello David Ribeiro Alves, Andrew Wong, Hao Hao, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8860
to review the following change.
Change subject: design-docs: improve cfile.md
......................................................................
design-docs: improve cfile.md
I've continually found the CFile abstraction difficult to place in
context with the higher-level DiskRowSet and lower-level BlockManager
abstractions. Every time I revisit the CFile code I have to re-research
these relationships and interactions. cfile.md is currently lacking in
these details, so this is an attempt to fix that.
WIP:
- I've added a bunch of TODOs where the doc is unclear, especially in
places where I'm not sure of the answer. I'd apprecitate reviewers
chiming in via comments if they can answer any of the questions.
- The markdown formatting of the doc is pretty attrocious, I intend to
fix this in a follow-up revision. I think the doc was written
originally as just a text file.
Change-Id: I770028bba3f7a49c96f32893c285221c84be39ce
---
M docs/design-docs/cfile.md
M docs/design-docs/tablet.md
2 files changed, 58 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/8860/1
--
To view, visit http://gerrit.cloudera.org:8080/8860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I770028bba3f7a49c96f32893c285221c84be39ce
Gerrit-Change-Number: 8860
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>