Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8860 )
Change subject: design-docs: improve cfile.md ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md File docs/design-docs/cfile.md: http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@64 PS1, Line 64: v1 -> v2 Would it be nice to briefly doc why do we need to have two versions of CFiles? http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@86 PS1, Line 86: group-varint coded Not sure if group-varint encoding is also deprecated for this? http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@100 PS1, Line 100: restart point" which is necessary for : faster binary searching. A bit more explanation on how it is related to faster binary searching? http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@133 PS1, Line 133: TODO(dan): No discussion of dictionary encoding, and the associated dictionary : block. > Not sure if we need all of the encodings described in this doc. For a list Yeah, I think it would be useful to link the more detail doc on .h http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@222 PS1, Line 222: queries like: "seek to the data block : containing the Nth entry in this CFile". Should we add some insight on from which layer these queries are issued? http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@260 PS1, Line 260: incompatible_features This is the first time mention 'incompatible_features'. And do not see it in the above diagram about footer? -- To view, visit http://gerrit.cloudera.org:8080/8860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I770028bba3f7a49c96f32893c285221c84be39ce Gerrit-Change-Number: 8860 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 00:13:29 +0000 Gerrit-HasComments: Yes
