Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8860 )
Change subject: design-docs: improve cfile.md ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md File docs/design-docs/cfile.md: http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@133 PS1, Line 133: TODO(dan): No discussion of dictionary encoding, and the associated dictionary : block. > +1 to leaving out the details of encodings here and just referring elsewher Do we actually have good descriptions of these encodings, though? http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@170 PS1, Line 170: ODO(dan): What's the branching factor of the B-Tree? : : TODO(dan): is the 'configured block size' the same for index and data blocks? : : TODO(dan): What does `Int` signify in the diagram below? There is some : explanation/background missing here. Is concurrent_btree.h the same btree? I was under the impression that concurrent_btree was just used for the MRS. > I think "Int" refers to an InternalNode on CBTree Good call. Completely obvious in retrospect, but I don't think I ever would have made that leap. I'll call it out more explicitly. http://gerrit.cloudera.org:8080/#/c/8860/1/docs/design-docs/cfile.md@199 PS1, Line 199: my best guess is > fwiw, I agree with your guess Yeah. I think the diagram may be overkill, but I think we should mention they are written to the CFile in post-order traversal with a link to https://en.wikipedia.org/wiki/Tree_traversal#Post-order. -- To view, visit http://gerrit.cloudera.org:8080/8860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I770028bba3f7a49c96f32893c285221c84be39ce Gerrit-Change-Number: 8860 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2017 20:58:30 +0000 Gerrit-HasComments: Yes
