Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8831 )
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8831/5/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/8831/5/src/kudu/rpc/rpc-test.cc@402 PS5, Line 402: ASSERT_EQ(0, metrics.num_server_connections_) << "Client should have 0 server connections"; > Some earlier version without {} gets flagged by LINT: Yea, I think it is OK with empty body inside braces {} or with 'continue;' without braces, but not happy with '{ continue; }' http://gerrit.cloudera.org:8080/#/c/8831/7/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/8831/7/src/kudu/server/server_base.cc@202 PS7, Line 202: -1 or I think 'any negative value' is sufficient explanation, since '-1' is just one particular example of a negative value and therefore redundant. -- To view, visit http://gerrit.cloudera.org:8080/8831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6161b9e753f05620784565a417d248acf8e7050a Gerrit-Change-Number: 8831 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 13:19:37 +0000 Gerrit-HasComments: Yes
