Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8831 )
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled ...................................................................... KUDU-2237: Allow idle server connection scanning to be disabled Currently, a server connection being idle for more than FLAGS_rpc_default_keepalive_time_ms ms will be closed. However, certain services (e.g. Impala) using KRPC may want to keep the idle connections alive for various reasons (e.g. sheer number of connections to re-establish, negotiation overhead in a secure cluster). To avoid idle connection from being closed, one currently have to set FLAGS_rpc_default_keepalive_time_ms to a very large value. This change implements a cleaner solution by disabling idle connection scanning if FLAGS_rpc_default_keepalive_time_ms is set to any negative value. This avoids the unnecessary overhead of scanning for idle server connections and alleviates the user from having to pick a random large number to make sure the connection is always kept alive. Change-Id: I6161b9e753f05620784565a417d248acf8e7050a Reviewed-on: http://gerrit.cloudera.org:8080/8831 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/rpc/messenger.h M src/kudu/rpc/reactor.cc M src/kudu/rpc/reactor.h M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc-test.cc M src/kudu/server/server_base.cc 6 files changed, 75 insertions(+), 28 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6161b9e753f05620784565a417d248acf8e7050a Gerrit-Change-Number: 8831 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
