Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/result_tracker.cc@275 PS1, Line 275: ErrorStatusPB_RpcErrorCodePB err, > warning: parameter 'err' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/rpc-test-base.h@306 PS1, Line 306: GetTokenResponsePB* resp, > warning: parameter 'resp' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/rpc-test-base.h@316 PS1, Line 316: void TestArgumentsInDiffPackage(const ReqDiffPackagePB *req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/rpc-test-base.h@317 PS1, Line 317: RespDiffPackagePB *resp, > warning: parameter 'resp' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/rpc_context.h File src/kudu/rpc/rpc_context.h: http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/rpc_context.h@219 PS1, Line 219: RpcContext(InboundCall *call); > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/service_if.h File src/kudu/rpc/service_if.h: http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/service_if.h@113 PS1, Line 113: void Handle(InboundCall* incoming) override; > warning: function 'kudu::rpc::GeneratedServiceIf::Handle' has a definition Done http://gerrit.cloudera.org:8080/#/c/8895/1/src/kudu/rpc/service_if.h@120 PS1, Line 120: virtual google::protobuf::Message* AllocResponsePB(const RpcMethodInfo* method); > warning: function 'kudu::rpc::GeneratedServiceIf::AllocResponsePB' has a de Done -- To view, visit http://gerrit.cloudera.org:8080/8895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I407b4782c9f3cd39ad3c6e0d21fd9542be34b118 Gerrit-Change-Number: 8895 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 20 Dec 2017 22:35:49 +0000 Gerrit-HasComments: Yes
