Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8895/2/src/kudu/rpc/service_if.h File src/kudu/rpc/service_if.h: http://gerrit.cloudera.org:8080/#/c/8895/2/src/kudu/rpc/service_if.h@118 PS2, Line 118: // Allocate a response PB for the given method. The memory returned is owned by the RpcContext. : // May be overridden by derived class. : virtual google::protobuf::Message* AllocResponsePB(const RpcMethodInfo* method_info); Not entirely sure this is the most preferable approach. Open to suggestions. -- To view, visit http://gerrit.cloudera.org:8080/8895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I407b4782c9f3cd39ad3c6e0d21fd9542be34b118 Gerrit-Change-Number: 8895 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Dec 2017 00:18:12 +0000 Gerrit-HasComments: Yes
