Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths ...................................................................... Patch Set 4: The code looks OK, but would be great to get some positive perf results. As I understand it, the tcmalloc issues with Impala are largely resolved after a bug fix, and this seems to increase complexity a bit. I can't see any significant perf difference using rpc-bench. -- To view, visit http://gerrit.cloudera.org:8080/8895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I407b4782c9f3cd39ad3c6e0d21fd9542be34b118 Gerrit-Change-Number: 8895 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 00:40:19 +0000 Gerrit-HasComments: No
