David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@9 PS3, Line 9: propagate nit: propagated http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10 PS3, Line 10: cliemt typo http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10 PS3, Line 10: for nit: the java http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10 PS3, Line 10: it nit: "this" or "timestamp propagation for this mode" http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@11 PS3, Line 11: propagate nit:propagated http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534 PS3, Line 534: propagated the the propagated http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java: http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92 PS3, Line 92: single single client? http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@141 PS3, Line 141: client.getLastPropagatedTimestamp() do we have a client.hasLastPropagatedTimestamp() that does this internally? if not could we add it? -- To view, visit http://gerrit.cloudera.org:8080/8837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89 Gerrit-Change-Number: 8837 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 05 Jan 2018 22:11:54 +0000 Gerrit-HasComments: Yes
