Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@9 PS3, Line 9: propagate > nit: propagated Done http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10 PS3, Line 10: H_S > nit: the java Done http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10 PS3, Line 10: r the > typo Done http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10 PS3, Line 10: pa > nit: "this" or "timestamp propagation for this mode" Done http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@11 PS3, Line 11: and upda > nit:propagated Done http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534 PS3, Line 534: the propagated > the propagated Oops, my bad. Update. http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java: http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92 PS3, Line 92: AUTO_F > single client? This comment is originally from L97. My understanding of why it was putting 'single operation' here is to refer flush mode AUTO_FLUSH_SYNC which return right after being flushed to the server for each write operation, compares to MANUAL_FLUSH mode which batching multiple writes. Maybe I should update the comment to specify the flush mode instead. I will do that. http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@141 PS3, Line 141: client.hasLastPropagatedTimestamp() > do we have a client.hasLastPropagatedTimestamp() that does this internally? Done -- To view, visit http://gerrit.cloudera.org:8080/8837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89 Gerrit-Change-Number: 8837 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 05 Jan 2018 23:19:49 +0000 Gerrit-HasComments: Yes
