David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode ...................................................................... Patch Set 4: (3 comments) thanks for addressing my nits, have a couple more and should be gtg http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@336 PS4, Line 336: received nit: the client received http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@339 PS4, Line 339: is not empty s/is not empty/"has been set" or somesuch http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@341 PS4, Line 341: synchronized not public? why -- To view, visit http://gerrit.cloudera.org:8080/8837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89 Gerrit-Change-Number: 8837 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 05 Jan 2018 23:22:57 +0000 Gerrit-HasComments: Yes
