zhen.zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 )
Change subject: KUDU-2238. DMS not flush under memory pressure. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8904/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/8904/2/src/kudu/tablet/tablet.cc@1909 PS2, Line 1909: double score = mem * mem_weight + size * (100 - mem_weight); > should this tie-breaker line now say "score == max_score && mem > mem_size" As both score and max_score are double, maybe it's not good to compare them, and "score==max_score" can represent the same logic, so I leave it here. BTW, I'm not sure how we do double comparison in kudu, is "std::abs(score-max_score) < 0.0001" good? -- To view, visit http://gerrit.cloudera.org:8080/8904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Gerrit-Change-Number: 8904 Gerrit-PatchSet: 3 Gerrit-Owner: zhen.zhang <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: zhen.zhang <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 07:30:38 +0000 Gerrit-HasComments: Yes
