Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 )
Change subject: KUDU-2238. DMS not flush under memory pressure. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8904/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/8904/1/src/kudu/tablet/tablet.cc@1897 PS1, Line 1897: double mem_weight = FLAGS_mem_weight_when_choose_best_dms_to_flush; instead of a new parameter maybe we should be basing this on whether the system is under memory pressure (eg using process_memory::UnderMemoryPressure)? ie if memory is tight we should prioritize on size, and if not, we should prioritize on retention? Then we wouldn't need the new tunable (which I'm not sure how to tune well) -- To view, visit http://gerrit.cloudera.org:8080/8904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Gerrit-Change-Number: 8904 Gerrit-PatchSet: 1 Gerrit-Owner: zhen.zhang <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Dec 2017 17:59:26 +0000 Gerrit-HasComments: Yes
