Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 )
Change subject: KUDU-2238. DMS not flush under memory pressure. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8904/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/8904/2/src/kudu/tablet/tablet.cc@1909 PS2, Line 1909: (size == retention_size && mem > mem_size)) { > As both score and max_score are double, maybe it's not good to compare them Good point. In this case I think we should go with something like: score > max_score - 1 && mem > mem_size (we don't need to worry about std::abs since we already compared above the case where score > max_score). Since the units of score is bytes*100 here we expect large numbers and so I think "- 1" is pretty reasonable vs 0.0001 or something. -- To view, visit http://gerrit.cloudera.org:8080/8904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Gerrit-Change-Number: 8904 Gerrit-PatchSet: 2 Gerrit-Owner: zhen.zhang <zhangz...@xiaomi.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: zhen.zhang <zhangz...@xiaomi.com> Gerrit-Comment-Date: Wed, 17 Jan 2018 07:35:44 +0000 Gerrit-HasComments: Yes
