Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 )
Change subject: KUDU-2202: support for removing data directories (take two) ...................................................................... Patch Set 7: (1 comment) With the metadata dir patch in, it's probably worth at least discussing (and maybe testing) the ways in which affects the remove tool's behavior. I don't think much changes, but something like: - Metadata dirs in WAL dir: removing any data dir is fine. No configuration changes necessary. - Metadata dirs in the first data dir: This is also fine, but further deployments must now specify the metadata dir, as it is no longer referenced in fs_data_dirs. - Metadata dirs in any other directory: same as the WAL case. http://gerrit.cloudera.org:8080/#/c/8978/7/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/8978/7/src/kudu/fs/fs_manager.cc@347 PS7, Line 347: if (!missing_roots.empty() && !opts_.read_only) { > huh, is this an existing bug? if you use an fs_manager tool and pass an ext missing_roots will only be non-empty if opts.update_on_disk is true (as per L292). This should probably be in a comment. -- To view, visit http://gerrit.cloudera.org:8080/8978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacb650115bcdf055542ef2777641a3201fc8e30b Gerrit-Change-Number: 8978 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 18 Jan 2018 22:44:49 +0000 Gerrit-HasComments: Yes
