Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 )
Change subject: KUDU-2202: support for removing data directories (take two) ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/8978/8/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/8978/8/src/kudu/fs/data_dirs.cc@699 PS8, Line 699: RETURN_NOT_OK_PREPEND( : PathInstanceMetadataFile::CheckIntegrity(loaded_instances), : Substitute("could not verify integrity of files after data directory update: $0", : JoinStrings(GetDataDirs(), ","))); nit: could merge this CheckIntegrity with the above with: if (opts_.consistency_check != ConsistencyCheckBehavior::IGNORE_INCONSISTENCY) { RETURN_NOT_OK(CheckIntegrity()); } This seems more explicitly aligned with the ConsistencyCheckBehavior enums (ie if we're ignoring inconsistencies, there's no need to check integrity). I guess with the current approach you can distinguish the error messages. Not a critical change at all, so up to you. http://gerrit.cloudera.org:8080/#/c/8978/8/src/kudu/fs/data_dirs.cc@812 PS8, Line 812: IGNORE_CONSISTENCY nit: IGNORE_INCONSISTENCY -- To view, visit http://gerrit.cloudera.org:8080/8978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacb650115bcdf055542ef2777641a3201fc8e30b Gerrit-Change-Number: 8978 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 20 Jan 2018 01:13:59 +0000 Gerrit-HasComments: Yes
